Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename variables for analyze functions (close #187) #192

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Conversation

mattroumaya
Copy link
Contributor

Overview

For Analyze_Fisher() and Analyze_Chisq():

  • N_Site becomes N
  • Prop_Site becomes Prop
  • TotalCount_Site becomes TotalCount

Test Notes/Sample Code

To test that update is successful:

df <- Disp_Map(dfDisp = safetyData::adam_adsl, strCol = "DCREASCD", strReason = "adverse event")
df <- Transform_EventCount(df, cCountCol = "Count")
df <- Analyze_Fisher(df)
df <- Flag(df, strColumn = 'Estimate', vThreshold = c(0, 1))
df <- Summarize(df)

Risk Assessment

Risk: Medium
Mitigation Strategy:

  • Qualification Testing - to be completed pre release
  • Unit Testing - not yet created
  • Code Review - Included via PR review
  • QC Checklist - To be included with Release
  • Automated Testing - Package Checks via GitHub Actions

@jwildfire jwildfire merged commit adbd282 into dev Feb 25, 2022
@mattroumaya mattroumaya deleted the fix-187 branch April 12, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bugfix: Analyze_Fisher() + Analyze_Chisq() do not have "N" column for Summarize()
2 participants