Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix country overview text #1908

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Fix country overview text #1908

merged 3 commits into from
Oct 23, 2024

Conversation

lauramaxwell
Copy link
Contributor

Overview

Update Report_OverviewText and Report_Setup to handle country overview text properly. also deals with two existing bugs that displayed only red flag counts in the description and calculated no_alert_groups incorrectly.

Previous text:
image

Updated text:
image

Test Notes/Sample Code

Connected Issues

  • Closes #XXX

@lauramaxwell lauramaxwell marked this pull request as ready for review October 23, 2024 20:33
Copy link
Contributor

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great as long as tests pass!

@lauramaxwell lauramaxwell merged commit 6758c82 into dev Oct 23, 2024
6 checks passed
@lauramaxwell lauramaxwell deleted the fix-country-overview-text branch October 23, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants