-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rbm-viz
v2.1.0.
#1856
Add rbm-viz
v2.1.0.
#1856
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Maybe @jonthegeek should take a look to see if these updates add events with all of the information he needs for use in gsm.app
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This definitely looks interesting! For the moment it still makes sense for me to wrap my own version of the widget, but I'll definitely take a close look when this is merged to see what's left in my version that isn't over here, and whether it makes sense to add issues here (or in rbm-viz) to sync the versions.
@samussiah are you still working on this, or is it in draft by accident? |
@lauramaxwell - I'm waiting for feedback from the Gismo UI team. It sounds like this event will need to be triggered by the widget dropdowns as well. It might work for @jonthegeek's purposes with a dedicated event listener on the |
I'm trying to keep things neatly namespaces, then recombine as makes sense. That way these could eventually work for selecting two sites to compare, for example. |
…a before dispatching event.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
working great, for me! feel free to merge, @samussiah
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super cool!
Overview
Adds new
riskSignalSelected
event that can be monitored by any ancestor of the widget (barChart
,scatterPlot
,timeSeries
,groupOverview
). Returns the {gsm} data associated with the clicked risk signal.The event also fires when the widget-level group dropdown changes. For the time series, the event should return the latest data point.
Test Notes/Sample Code
riskSignalSelected
:Connected Issues
index.js
#1855riskSignalSelected
event. #1860