Add a function to cleanly convert Params to Labels. #1791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #1790. TODO before this PR is done: Consider adding to workflows and/or checking for it in report functions.
Add to pkgdown.
We'll likely want to push this back a step (so lStudy already uses the labels), but this function already implemented a miniature version of this so it was a safe place to add it.
Oops, glad I noticed that I skipped that step! I intend to use this in gsm.app.
|
@lauramaxwell This one is ready to review, and will be useful in {gsm.app} in lots of places! (I don't need to export another function, I don't think, despite what I just said) |
lauramaxwell
requested changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Function to add a
Labelscolumn todfGroups.Closes #1790.
Test Notes/Sample Code
Notes: