Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit snapshot date subset to Widget_GroupOverview. #1789

Merged
merged 10 commits into from
Aug 20, 2024
Merged

Conversation

samussiah
Copy link
Contributor

@samussiah samussiah commented Aug 19, 2024

Overview

Test Notes/Sample Code

load_all()
Widget_GroupOverview(
  dfResults = filter_by_latest_SnapshotDate(reportingResults),
  dfMetrics = reportingMetrics,
  dfGroups = reportingGroups
)

Report_MetricTable(
  dfResults = reportingResults %>%
      dplyr::filter(.data$MetricID == 'kri0001') %>%
      filter_by_latest_SnapshotDate(),
  dfGroups = reportingGroups
)

Notes:
@jonthegeek - #1788 ties into this issue in {gsm.app}. Allows you to generate the analysis output table with all groups in addition to only groups flagged for the metric.

@jonthegeek
Copy link
Contributor

@samussiah I think what we really want for that ticket is to show all of the results, but highlight the selected site (similar to what we do with the plots). Is that on your radar?

Copy link
Contributor

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be good to standardize on filter_by_latest_SnapshotDate() so we can use the same messaging everywhere that it's used.

R/Widget_GroupOverview.R Outdated Show resolved Hide resolved
@samussiah
Copy link
Contributor Author

@samussiah I think what we really want for that ticket is to show all of the results, but highlight the selected site (similar to what we do with the plots). Is that on your radar?

That's not in the scope of {gsm} but being able to display all rows at least allows {gsm.app} to find the relevant row and highlight it or sort it first.

@samussiah samussiah requested a review from jonthegeek August 20, 2024 14:51
samussiah and others added 2 commits August 20, 2024 10:58
I also added some rlang magic to report the name of the df that we're filtering.
Copy link
Contributor

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@lauramaxwell lauramaxwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working well for me, both in standalone function call and in reporting workflow.

@lauramaxwell lauramaxwell merged commit 71c27e3 into dev Aug 20, 2024
5 checks passed
@lauramaxwell lauramaxwell deleted the fix-1787 branch August 20, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants