-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit snapshot date subset to Widget_GroupOverview
.
#1789
Conversation
@samussiah I think what we really want for that ticket is to show all of the results, but highlight the selected site (similar to what we do with the plots). Is that on your radar? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be good to standardize on filter_by_latest_SnapshotDate()
so we can use the same messaging everywhere that it's used.
That's not in the scope of {gsm} but being able to display all rows at least allows {gsm.app} to find the relevant row and highlight it or sort it first. |
I also added some rlang magic to report the name of the df that we're filtering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
working well for me, both in standalone function call and in reporting workflow.
Overview
dfResults
argument toWidget_GroupOverview
on latest snapshot date. #1787Report_MetricTable
that controls howdfResults
is subset. #1788Test Notes/Sample Code
Notes:
@jonthegeek - #1788 ties into this issue in {gsm.app}. Allows you to generate the analysis output table with all groups in addition to only groups flagged for the metric.