Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Study_Assess not running with missing data #476

Closed
mattroumaya opened this issue May 20, 2022 · 0 comments · Fixed by #480
Closed

Bugfix: Study_Assess not running with missing data #476

mattroumaya opened this issue May 20, 2022 · 0 comments · Fixed by #480
Assignees
Labels
bug Something isn't working
Milestone

Comments

@mattroumaya
Copy link
Contributor

Expected Behavior

Study_Assess errors out when expected data is not found in lData

Current Behavior

RunStep passes params to FilterDomain without a df parameter here, which causes is_mapping_valid to error out when checking is.data.frame() on a missing parameter.

Possible Solution

Check for if(any(c('df', 'dfs') %in% names(params)) here, and then run do.call, else skip the run and pass lChecks and lChecks$status == FALSE back to RunAssessment

Or, possibly another option upstream, but needs some consideration in order to output useful error checking.

Steps to Reproduce

lData <- list(
  dfAE = clindata::rawplus_ae,
  dfSUBJ = clindata::rawplus_subj
)

x <- Study_Assess(lData = lData)
@mattroumaya mattroumaya added the bug Something isn't working label May 20, 2022
@mattroumaya mattroumaya added this to the v1.0.0 milestone May 20, 2022
@mattroumaya mattroumaya self-assigned this May 20, 2022
mattroumaya added a commit that referenced this issue May 20, 2022
mattroumaya added a commit that referenced this issue May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant