Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QC: Flag QC Checklist Items #229

Closed
mattroumaya opened this issue Mar 3, 2022 · 0 comments · Fixed by #240
Closed

QC: Flag QC Checklist Items #229

mattroumaya opened this issue Mar 3, 2022 · 0 comments · Fixed by #240
Assignees
Milestone

Comments

@mattroumaya
Copy link
Contributor

QC Details

Additional Comments

  1. Update @params
  • Minor fix: clean up capitalization and punctuation for @params
  1. Update stopifnot() checks
  • Check that SiteID %in% names(dfAnalyzed)
  • Check that length(strColumn) == 1
  • Add descriptions to stopifnot() errors
  1. Update unit tests
  • Add test to confirm SiteID is in input
  • Currently uses safetyData for unit tests
  • Need test to confirm input data contains columns: SiteID, strColumn (default = "Pvalue")
  • Need to add explicit test for expected output column names
@mattroumaya mattroumaya added this to the v0.2.0 milestone Mar 3, 2022
@mattroumaya mattroumaya self-assigned this Mar 4, 2022
mattroumaya added a commit that referenced this issue Mar 4, 2022
jwildfire added a commit that referenced this issue Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant