Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QC: Analyze_Chisq QC Checklist Items #221

Closed
mattroumaya opened this issue Mar 2, 2022 · 0 comments · Fixed by #262
Closed

QC: Analyze_Chisq QC Checklist Items #221

mattroumaya opened this issue Mar 2, 2022 · 0 comments · Fixed by #262
Assignees
Milestone

Comments

@mattroumaya
Copy link
Contributor

QC Details

Additional Comments

  1. Update roxygen details
  • Suggested fix: The input data (dfTransformed) for Analyze_Chisq is typically created using \code{\link{Transform_EventCount}} and should be one record per site with required columns for...
  • For input data, change Count --> TotalCount
  1. Add statistical assumptions section to roxygen

  2. Update external dependencies section in roxygen

  • For imports section
    • Add @import dplyr
    • Add @importFrom tidyr unnest
    • Remove as.formula from @importFrom stats
    • Remove map_df from @importFrom purrr
  1. Update stopifnot() checks
  • NA handling for SiteID needed
  • Check that length(strOutcome) == 1
  • Add descriptions to stopifnot() errors
  1. Declare dependencies with ::
@jwildfire jwildfire added this to the v0.3.0 milestone Mar 3, 2022
@mattroumaya mattroumaya self-assigned this Mar 9, 2022
@mattroumaya mattroumaya linked a pull request Mar 9, 2022 that will close this issue
mattroumaya added a commit that referenced this issue Mar 11, 2022
fixes #221 - qc updates for Analyze_Chisq()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants