Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: When metrics don't have any data, don't print the header in the report #1937

Closed
lauramaxwell opened this issue Nov 8, 2024 · 0 comments · Fixed by #1953
Closed

Bugfix: When metrics don't have any data, don't print the header in the report #1937

lauramaxwell opened this issue Nov 8, 2024 · 0 comments · Fixed by #1953
Assignees
@lauramaxwell @zdz2101
Milestone
v2.2.0

Comments

@lauramaxwell
Copy link
Contributor

Feature Details

Right now, we always print the headers for all metrics that exist in the 2_metrics folder. IF these aren't all being created, than the headers will still exist in the report. We should not print out the headers for metrics that we aren't running/don't have data for.

Example Code

Possible Implementation

Additional Comments
@lauramaxwell lauramaxwell added this to the v2.2.0 milestone Nov 8, 2024
@lauramaxwell lauramaxwell changed the title Feature: When metrics don't have any data, don't print the header in the report Bugfix: When metrics don't have any data, don't print the header in the report Nov 11, 2024
@zdz2101 zdz2101 linked a pull request Nov 19, 2024 that will close this issue
Closes #1937 Display only results of metrics where data is available in reports #1953
Merged
lauramaxwell added a commit that referenced this issue Nov 20, 2024
@lauramaxwell
Merge pull request #1953 from Gilead-BioStats/fix-1937
5e90344 
Closes #1937 Display only results of metrics where data is available in reports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lauramaxwell lauramaxwell

@zdz2101 zdz2101

Labels
None yet
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging a pull request may close this issue.

Closes #1937 Display only results of metrics where data is available in reports Gilead-BioStats/gsm
2 participants
@lauramaxwell @zdz2101