Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #21 #25 remove mention of _all in yamls and edits mapping spec vignette #27

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

Closes #21 #25 remove mention of _all in yamls and edits mapping spec vignette #27

wants to merge 3 commits into from

Conversation

zdz2101
Copy link
Contributor

@zdz2101 zdz2101 commented Feb 10, 2025

Overview

Looks like all the mentions of _all were already removed in yamls but a small reference to it still existed in ApplySpec() so I removed it to prevent code-bloat/future confusion

@zdz2101 zdz2101 linked an issue Feb 10, 2025 that may be closed by this pull request
refactor yamls to remove _all param/field #21
Open
@zdz2101 zdz2101 changed the base branch from main to dev February 10, 2025 16:57
@zdz2101 zdz2101 changed the title Closes #21 remove mention of _all in yamls Closes #21 #25 remove mention of _all in yamls and edits mapping spec vignette Feb 10, 2025
@zdz2101 zdz2101 linked an issue Feb 10, 2025 that may be closed by this pull request
Updates to Mapping Specification VIgnette #25
Open
@lauramaxwell
Copy link
Contributor

{gsm.kri} uses _all in the report_kri_site and report_kri_country yaml workflows, so we need to make sure we can handle those workflows with this update. @zdz2101 - would you mind taking a look in {gsm.kri} to align these two packages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updates to Mapping Specification VIgnette refactor yamls to remove _all param/field
2 participants
@zdz2101 @lauramaxwell