-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Structure file support to world-edit scarpet #34
Conversation
to .nbt files.
and added load. idk if it works
Another reason to use a subfolder is in case more data is saved (e.g. user preferences) those don't have to be filtered out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments and suggestions.
@altrisi I feel like there is a better way to this with only regex...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay! Wasn't complaining, but ok :P
For an actual name, that might be good, if we don't do something like ScarpetEdit (BlingEdit, World Edit). For the script name, hence the command, I'd do something shot like |
Other than the name change, which can be done in a separate pr, what's holding us back from accepting this pr? |
Approvals only, I think. I have testing and reviewing this somewhere in my list of things to-do in the very near future (and actually one review comment already pending). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: The app doesn't load since 5cc6dee
Failed to build command system for world-edit thus failed to load the app
Number of parameters in function structure[world-edit] doesn't match parameters for a command
Other than that and the comments I left, what I was able to check looks good.
I commented the At the moment I can contribute only from Mobile and I don't know if there is a better way to suggest changes... |
ok @altrisi I've fixed the command building problems, you can approve now |
Actually wait, Ive still gotta finish some stuff with entity saving, otherwise it's done. |
There is a number of reasons why I chose structure files and not schematics like in regular world-edit:
Im contemplating saving them to a subfolder, but im not too sure tbh. You know what, imma do a poll:
Poll: react with 👍 if I should add .nbt files to a subfolder, and 👎 if I should keep it like it is. Keep in mind #31 , in which translations will be moved into their own folder.
Also, I still need to figure out the structure suggestions, help would be appreciated.