Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Structure file support to world-edit scarpet #34

Merged
merged 40 commits into from
Jan 31, 2021
Merged

Conversation

Ghoulboy78
Copy link
Owner

There is a number of reasons why I chose structure files and not schematics like in regular world-edit:

  1. .nbt files can be loaded from structure blocks from vanilla
  2. scarpet can actually save .nbt files, not need to rename file extensions (especially for those who don't know how)
  3. Noobs who don't know about schematics wont be bothering masa (poor fellow deserves a break)
  4. The way schematics save is a tad more efficient, but not replicable in scarpet.

Im contemplating saving them to a subfolder, but im not too sure tbh. You know what, imma do a poll:
Poll: react with 👍 if I should add .nbt files to a subfolder, and 👎 if I should keep it like it is. Keep in mind #31 , in which translations will be moved into their own folder.

Also, I still need to figure out the structure suggestions, help would be appreciated.

world-edit.sc Outdated Show resolved Hide resolved
@altrisi
Copy link
Collaborator

altrisi commented Jan 5, 2021

Another reason to use a subfolder is in case more data is saved (e.g. user preferences) those don't have to be filtered out.

CONTRIBUTING.md Outdated Show resolved Hide resolved
docs/Documentation.md Outdated Show resolved Hide resolved
world-edit.sc Outdated Show resolved Hide resolved
Copy link
Collaborator

@altrisi altrisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments and suggestions.

world-edit.sc Outdated Show resolved Hide resolved
world-edit.sc Show resolved Hide resolved
world-edit.sc Show resolved Hide resolved
world-edit.sc Outdated Show resolved Hide resolved
world-edit.sc Show resolved Hide resolved
@Ghoulboy78 Ghoulboy78 added this to the v1.2.0 milestone Jan 7, 2021
Copy link
Collaborator

@Firigion Firigion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Wasn't complaining, but ok :P

@Firigion
Copy link
Collaborator

Firigion commented Jan 23, 2021

For an actual name, that might be good, if we don't do something like ScarpetEdit (BlingEdit, World Edit). For the script name, hence the command, I'd do something shot like /we or /se, and the corresponding se.sc, or whatever.

@Firigion
Copy link
Collaborator

Other than the name change, which can be done in a separate pr, what's holding us back from accepting this pr?

@altrisi
Copy link
Collaborator

altrisi commented Jan 23, 2021

Approvals only, I think. I have testing and reviewing this somewhere in my list of things to-do in the very near future (and actually one review comment already pending).

Copy link
Collaborator

@altrisi altrisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: The app doesn't load since 5cc6dee

Failed to build command system for world-edit thus failed to load the app Number of parameters in function structure[world-edit] doesn't match parameters for a command

Other than that and the comments I left, what I was able to check looks good.

world-edit.data/en_us.txt Outdated Show resolved Hide resolved
world-edit.sc Show resolved Hide resolved
@BisUmTo
Copy link
Collaborator

BisUmTo commented Jan 25, 2021

I commented the it_it.txt file with some grammar corrections.

At the moment I can contribute only from Mobile and I don't know if there is a better way to suggest changes...

@Ghoulboy78
Copy link
Owner Author

Ghoulboy78 commented Jan 27, 2021

ok @altrisi I've fixed the command building problems, you can approve now

@Ghoulboy78
Copy link
Owner Author

Actually wait, Ive still gotta finish some stuff with entity saving, otherwise it's done.

world-edit.data/langs/it_it.json Outdated Show resolved Hide resolved
world-edit.data/langs/it_it.json Outdated Show resolved Hide resolved
world-edit.data/langs/it_it.json Outdated Show resolved Hide resolved
still wip, but gonna fix that in #43
(soz @BisUmTo but ive not spoken in italian for a while now, especially in lockdown...)
cos #45 messed some stuff up
@Ghoulboy78 Ghoulboy78 merged commit 76e6e23 into master Jan 31, 2021
@Ghoulboy78 Ghoulboy78 deleted the schematic branch January 31, 2021 08:37
Firigion added a commit that referenced this pull request Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants