Add new variables for quasselweb https #1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[LSIO Quassel-web container](https://github.com/linuxserver/docker-quassel-web) added a new variable `QUASSEL_HTTPS` to control whether or not the Quassel web client uses https. Added this new variable to the quasselweb app, as well as one to set the https port if choosing to use https.
|
@nemchik any idea why the action failed? |
nemchik
approved these changes
Nov 19, 2023
rate limits on pulling images. it almost always fails. i should just remove it at this point. i have not yet thought of a better way to check if an image exists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Purpose
LSIO Quassel-web container added a new variable
QUASSEL_HTTPSto control whether or not the Quassel web client uses https.Approach
Added this new variable to the quasselweb app, as well as one to set the https port if choosing to use https.
Open Questions and Pre-Merge TODOs
Check all boxes as they are completed
Learning
N/A
Requirements
Check all boxes as they are completed