-
-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to MinecraftAuth #4779
Port to MinecraftAuth #4779
Conversation
core/src/main/java/org/geysermc/geyser/session/GeyserSession.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also please undo changes to mappings
core/src/main/java/org/geysermc/geyser/session/GeyserSession.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/session/PendingMicrosoftAuthentication.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on my end; seems to work fine (including the transformation from refresh token -> auth chain). LGTM!
...eysermc/geyser/translator/protocol/bedrock/BedrockSetLocalPlayerAsInitializedTranslator.java
Outdated
Show resolved
Hide resolved
…rock/BedrockSetLocalPlayerAsInitializedTranslator.java Co-authored-by: chris <github@onechris.mozmail.com>
# Conflicts: # core/src/main/java/org/geysermc/geyser/GeyserImpl.java
core/src/main/java/org/geysermc/geyser/session/GeyserSession.java
Outdated
Show resolved
Hide resolved
…tLoginComplete is called
https://github.com/GeyserMC/Geyser/actions/runs/10071963678/job/27843011435#step:4:236 |
Java 19, it would seem according to Javadocs unfortunately. |
Updates MCPL, MinecraftAuth is the new auth lib. Refresh tokens are useless now. The entire auth chain needs to be stored instead with MinecraftAuth.
Needs review because the behaviour isn't 1:1 as before.
Code is untested.