Port to MinecraftAuth #4779
Merged
Port to MinecraftAuth #4779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kas-tle
added
the
PR: Needs Testing
|
|
core/src/main/java/org/geysermc/geyser/session/GeyserSession.java
Outdated
Show resolved
Hide resolved
Konicai
reviewed
Jul 13, 2024
core/src/main/java/org/geysermc/geyser/session/GeyserSession.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/session/PendingMicrosoftAuthentication.java
Outdated
Show resolved
Hide resolved
onebeastchris
approved these changes
Jul 20, 2024
...eysermc/geyser/translator/protocol/bedrock/BedrockSetLocalPlayerAsInitializedTranslator.java
Outdated
Show resolved
Hide resolved
…rock/BedrockSetLocalPlayerAsInitializedTranslator.java Co-authored-by: chris <github@onechris.mozmail.com>
# Conflicts: # core/src/main/java/org/geysermc/geyser/GeyserImpl.java
Camotoy
reviewed
Jul 23, 2024
Camotoy
reviewed
Jul 24, 2024
core/src/main/java/org/geysermc/geyser/session/GeyserSession.java
Outdated
Show resolved
Hide resolved
…tLoginComplete is called
Camotoy
approved these changes
Jul 24, 2024
|
https://github.com/GeyserMC/Geyser/actions/runs/10071963678/job/27843011435#step:4:236 |
|
Java 19, it would seem according to Javadocs unfortunately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates MCPL, MinecraftAuth is the new auth lib. Refresh tokens are useless now. The entire auth chain needs to be stored instead with MinecraftAuth.
Needs review because the behaviour isn't 1:1 as before.
Code is untested.