-
-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preferences system and api #3958
base: master
Are you sure you want to change the base?
Conversation
Konicai
commented
Jul 10, 2023
•
edited by onebeastchris
Loading
edited by onebeastchris
- actually expose the system to the api
- fix onUpdate
- allow not providing a cumulus Component (don't show in settings form)
- player leave event
- testing
- javadoc
- i'll write more here later when this is more filled in
@@ -95,4 +98,12 @@ public interface GeyserConnection extends Connection, CommandSource { | |||
*/ | |||
@NonNull | |||
Set<String> fogEffects(); | |||
|
|||
<T> void storePreference(@NonNull PreferenceKey<T> key, @NonNull Preference<T> preference); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Javadocs here please. We should emphasize this system is Geyser and not Bedrock.
|
||
import java.util.Objects; | ||
|
||
public abstract class Preference<T> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Javadoc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after the structure is finalized :p