Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add csv support #126

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Feature/add csv support #126

merged 4 commits into from
Oct 1, 2024

Conversation

jaymarvels
Copy link
Contributor

  • Added in csv import support.
  • Added in csv export support
  • Utilised csvhelper for heavy lifting (duel licensed so safe to use)
  • Tested against a proj running CMS 12.29.0 and commerce 14.12.0

@jaymarvels
Added csv support
479602b 
Added in csv import and export support. Utilised csvhelper for heavy lifting
@jaymarvels
Fixed incorrect using directives
22c993c
@jaymarvels
More code clean up
1bb7136
@jaymarvels jaymarvels mentioned this pull request Jun 26, 2024
Closed
jevgenijsp
jevgenijsp requested changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@jevgenijsp jevgenijsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

The code overall looks Ok, but I found some places that can be cleaned by reducing code duplication.

src/Geta.NotFoundHandler.Admin/Areas/GetaNotFoundHandlerAdmin/Pages/Administer.cshtml.cs Outdated Show resolved Hide resolved
src/Geta.NotFoundHandler.Admin/Areas/GetaNotFoundHandlerAdmin/Pages/Administer.cshtml.cs Outdated Show resolved Hide resolved
src/Geta.NotFoundHandler.Admin/Areas/GetaNotFoundHandlerAdmin/Pages/Administer.cshtml.cs Outdated Show resolved Hide resolved
src/Geta.NotFoundHandler.Admin/Areas/GetaNotFoundHandlerAdmin/Pages/Administer.cshtml.cs Outdated Show resolved Hide resolved
...oundHandler.Admin/Areas/GetaNotFoundHandlerAdmin/Pages/Infrastructure/IFormFileExtensions.cs Show resolved Hide resolved
src/Geta.NotFoundHandler/Core/Redirects/RedirectsCsvParser.cs Outdated Show resolved Hide resolved
src/Geta.NotFoundHandler/Geta.NotFoundHandler.csproj Outdated Show resolved Hide resolved
@jevgenijsp jevgenijsp merged commit 05c047f into Geta:master Oct 1, 2024
1 check failed
@jaymarvels
Copy link
Contributor Author

@jevgenijsp Thanks for doing this, I was slowly getting around to completing. Glad its in the package now.

@jevgenijsp
Copy link
Contributor

@jaymarvels Thanks for contributing! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jevgenijsp jevgenijsp jevgenijsp approved these changes

Assignees
No one assigned
Labels
ready for dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaymarvels @jevgenijsp @valdisiljuconoks