Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LogInForm: Labels overlay input content when injected by the browser #656

Closed
2 tasks
benjamincharity opened this issue Feb 14, 2018 · 2 comments · Fixed by #1609
Closed
2 tasks

LogInForm: Labels overlay input content when injected by the browser #656

benjamincharity opened this issue Feb 14, 2018 · 2 comments · Fixed by #1609
Assignees
@benjamincharity
Labels
Focus: component Issues concerning a specific component Needs: exploration Issues that need more information before being worked on Type: bug An implemented item with undesired effects

Comments

@benjamincharity
Copy link
Contributor

benjamincharity commented Feb 14, 2018 •
edited
Loading

This was originally reported by someone using LastPass but it has now been reported by someone only using Chrome's injection.

After letting Chrome inject saved information:
image (1)

Clicking anywhere on the page seems to trigger a change detection cycle to update it:
image (2)

  • Determine if there is an event we can tie into to trigger a UI update after injection
  • Add tests (if possible)
@benjamincharity benjamincharity self-assigned this Feb 14, 2018
@benjamincharity benjamincharity added Focus: component Issues concerning a specific component Needs: exploration Issues that need more information before being worked on P2: Urgent Status: Core App Needs Today Type: bug An implemented item with undesired effects labels Feb 14, 2018
@benjamincharity benjamincharity removed their assignment Mar 7, 2018
@benjamincharity benjamincharity mentioned this issue Jun 6, 2018
Closed
@benjamincharity benjamincharity self-assigned this Jul 24, 2019
@benjamincharity benjamincharity changed the title LogInForm: LastPass fills in form but form isn't updated as valid until the page is interacted with LogInForm: Labels overlay input content when injected by the browser Jul 24, 2019
@benjamincharity
Copy link
Contributor Author

Cannot replicate with 1Password or LastPass

@benjamincharity
Copy link
Contributor Author

Cannot replicate in Firefox with autofill

benjamincharity added a commit that referenced this issue Jul 26, 2019
@benjamincharity
fix(LoginForm): correctly fire stateChange when autofilled by the bro…
b6488c0 
…wser

The incorrect element was being passed to the autofill monitor.

ISSUES CLOSED: #656
@benjamincharity benjamincharity mentioned this issue Jul 26, 2019
Merged
benjamincharity added a commit that referenced this issue Jul 29, 2019
@benjamincharity
fix(Input): correctly manage autofill on the correct element
6524f09 
Moved autofill init to afterViewInit and call it on the correct element

ISSUES CLOSED: #656
benjamincharity added a commit that referenced this issue Jul 29, 2019
@benjamincharity
fix(Input): correctly manage autofill on the correct element
e6d1826 
The incorrect element was being passed to the autofill monitor.

ISSUES CLOSED: #656
benjamincharity added a commit that referenced this issue Jul 29, 2019
@benjamincharity
fix(Input): correctly manage autofill on the correct element
d9e54dc 
The incorrect element was being passed to the autofill monitor.

ISSUES CLOSED: #656
benjamincharity added a commit that referenced this issue Jul 29, 2019
@benjamincharity
fix(Input): correctly manage autofill on the correct element
7e5e4c0 
The incorrect element was being passed to the autofill monitor.

ISSUES CLOSED: #656
benjamincharity added a commit that referenced this issue Jul 30, 2019
@benjamincharity
fix(Input): correctly manage autofill on the correct element
a7e318f 
The incorrect element was being passed to the autofill monitor.

ISSUES CLOSED: #656
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjamincharity benjamincharity

Labels
Focus: component Issues concerning a specific component Needs: exploration Issues that need more information before being worked on Type: bug An implemented item with undesired effects
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

656 autofill bug GetTerminus/terminus-ui
1 participant
@benjamincharity