Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Date Cohort #1819

Closed
3 tasks done
dpeet opened this issue Dec 5, 2019 · 0 comments
Closed
3 tasks done

Improve Date Cohort #1819

dpeet opened this issue Dec 5, 2019 · 0 comments
Assignees
@benjamincharity
Labels
Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) Type: feature Functionality that doesn't currently exist

Comments

@dpeet
Copy link

dpeet commented Dec 5, 2019 •
edited by benjamincharity
Loading

Currently when a cohort is selected, the date ranges are disabled. If we choose to disable the component, there is not a significant enough visual difference. Instead of disabling the date ranges, if a user chooses to edit the range, the dropdown should automatically change to "Custom Range"

The motivation of the request is for Campaign Overview, to allow it to remain (visually) in line with tactic detail enhancements

  • Do not disable date range unless the cohort date range is disabled
  • When user interacts with the date range, the select list should automatically switch to 'custom dates'
  • Add test
@dpeet dpeet added Needs: planning Items that need discovery/refinement/details/etc Type: bug An implemented item with undesired effects labels Dec 5, 2019
@benjamincharity benjamincharity added Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) Type: feature Functionality that doesn't currently exist and removed Type: bug An implemented item with undesired effects Needs: planning Items that need discovery/refinement/details/etc labels Dec 5, 2019
benjamincharity added a commit that referenced this issue Dec 11, 2019
@benjamincharity
feat(CohortDateRange): no longer blocks user from custom interaction …
c5da545 
…when allowed

When `allowCustomDates` is true, the user can manually adjust an existing cohort.

ISSUES CLOSED: #1819
benjamincharity added a commit that referenced this issue Dec 11, 2019
@benjamincharity
feat(CohortDateRange): no longer blocks user from custom interaction …
9346e04 
…when allowed

When `allowCustomDates` is true, the user can manually adjust an existing cohort.

ISSUES CLOSED: #1819
benjamincharity added a commit that referenced this issue Dec 16, 2019
@benjamincharity
feat(CohortDateRange): no longer blocks user from custom interaction …
8790d0a 
…when allowed

When `allowCustomDates` is true, the user can manually adjust an existing cohort.

ISSUES CLOSED: #1819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjamincharity benjamincharity

Labels
Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) Type: feature Functionality that doesn't currently exist
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benjamincharity @dpeet