Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SelectionList: The first option should always be selected when querying #1729

Closed
1 of 2 tasks
benjamincharity opened this issue Oct 1, 2019 · 0 comments · Fixed by #1731
Closed
1 of 2 tasks

SelectionList: The first option should always be selected when querying #1729

benjamincharity opened this issue Oct 1, 2019 · 0 comments · Fixed by #1731
Assignees
@benjamincharity
Labels
Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) Type: bug An implemented item with undesired effects

Comments

@benjamincharity
Copy link
Contributor

benjamincharity commented Oct 1, 2019 •
edited
Loading

Notice, when typing a query to narrow results, hitting enter selects the originally focused option. The first option should always be selected when querying.

NOTE: May want to handle with #1728 as they are closely related.

  • As the options narrow, keep the first option selected until the user interacts with the list
  • Add tests
@benjamincharity benjamincharity added Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) Type: bug An implemented item with undesired effects labels Oct 1, 2019
@benjamincharity benjamincharity self-assigned this Oct 1, 2019
benjamincharity added a commit that referenced this issue Oct 3, 2019
@benjamincharity
fix(SelectionList): first option now selected by default
b526249 
ISSUES CLOSED: #1729
@benjamincharity benjamincharity mentioned this issue Oct 3, 2019
Merged
benjamincharity added a commit that referenced this issue Oct 3, 2019
@benjamincharity
fix(SelectionList): first option now selected by default
fe14755 
ISSUES CLOSED: #1729
benjamincharity added a commit that referenced this issue Oct 3, 2019
@benjamincharity
fix(SelectionList): first option now selected by default
cd18162 
ISSUES CLOSED: #1729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjamincharity benjamincharity

Labels
Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) Type: bug An implemented item with undesired effects
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SelectionList bugs GetTerminus/terminus-ui
1 participant
@benjamincharity