Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button: Support icon only mode #1714

Closed
4 tasks done
benjamincharity opened this issue Sep 23, 2019 · 0 comments · Fixed by #1754
Closed
4 tasks done

Button: Support icon only mode #1714

benjamincharity opened this issue Sep 23, 2019 · 0 comments · Fixed by #1754
Assignees
@benjamincharity
Labels
Focus: component Issues concerning a specific component Project: Tactic Details Target: latest Issues related to the latest version of the library (master) Type: feature Functionality that doesn't currently exist

Comments

@benjamincharity
Copy link
Contributor

benjamincharity commented Sep 23, 2019 •
edited
Loading

We need to support button content that is only an icon.

  • Overwrite padding added by mat-raised-button to 8px (currently is 16px)
  • Add 8px padding to c-button__content (this way text content has a full 16px while icon only has
  • Add icon only example to demo
  • Move margin-right: .2em to c-button__icon instead of c-icon

Currently:
Screen Shot 2019-09-23 at 1.09.58 PM.png

Desired:
Screen Shot 2019-09-23 at 1.09.48 PM.png
@benjamincharity benjamincharity added Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) Type: feature Functionality that doesn't currently exist Project: Tactic Details labels Sep 23, 2019
@benjamincharity benjamincharity self-assigned this Oct 23, 2019
benjamincharity added a commit that referenced this issue Oct 23, 2019
@benjamincharity
feat(Button): support icon-only mode
af47194 
ISSUES CLOSED: #1714
@benjamincharity benjamincharity mentioned this issue Oct 23, 2019
Merged
benjamincharity added a commit that referenced this issue Oct 24, 2019
@benjamincharity
feat(Button): support icon-only mode
3575d3a 
ISSUES CLOSED: #1714
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjamincharity benjamincharity

Labels
Focus: component Issues concerning a specific component Project: Tactic Details Target: latest Issues related to the latest version of the library (master) Type: feature Functionality that doesn't currently exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(Button): support icon-only mode GetTerminus/terminus-ui
1 participant
@benjamincharity