Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LogInForm: Removed deprecated submit output #1469

Closed
2 tasks done
benjamincharity opened this issue Apr 18, 2019 · 0 comments · Fixed by #1737
Closed
2 tasks done

LogInForm: Removed deprecated submit output #1469

benjamincharity opened this issue Apr 18, 2019 · 0 comments · Fixed by #1737
Assignees
@benjamincharity
Labels
💥 BREAKING CHANGE 💥 This issue is a breaking change requiring a major version bump Focus: component Issues concerning a specific component Goal: Library Stabilization A task needed to get the library closer to it's final state Type: chore Something that needs to be done but is not a bug or addition

Comments

@benjamincharity
Copy link
Contributor

benjamincharity commented Apr 18, 2019 •
edited
Loading

💥BREAKING CHANGE 💥

  • Remove the deprecated submit emitter.
  • Update tests
@benjamincharity benjamincharity added Type: chore Something that needs to be done but is not a bug or addition Focus: component Issues concerning a specific component 💥 BREAKING CHANGE 💥 This issue is a breaking change requiring a major version bump Goal: Library Stabilization A task needed to get the library closer to it's final state Target: v14 labels Apr 18, 2019
@benjamincharity benjamincharity modified the milestone: v15 Jun 24, 2019
@benjamincharity benjamincharity mentioned this issue Sep 4, 2019
Closed
@benjamincharity benjamincharity mentioned this issue Oct 3, 2019
Merged
@benjamincharity benjamincharity self-assigned this Oct 16, 2019
benjamincharity added a commit that referenced this issue Oct 16, 2019
@benjamincharity
fix(LoginForm): remove deprecated submit emitter
e78c4dd 
submit emitter removed in favor of submission

BREAKING CHANGE:
submit emitter removed in favor of submission

ISSUES CLOSED: #1469
@benjamincharity benjamincharity mentioned this issue Oct 16, 2019
Merged
benjamincharity added a commit that referenced this issue Oct 17, 2019
@benjamincharity
fix(LoginForm): remove deprecated submit emitter
5999abf 
submit emitter removed in favor of submission

BREAKING CHANGE:
submit emitter removed in favor of submission

ISSUES CLOSED: #1469
benjamincharity added a commit that referenced this issue Oct 25, 2019
@benjamincharity
fix(LoginForm): remove deprecated submit emitter
60f465d 
submit emitter removed in favor of submission

BREAKING CHANGE:
submit emitter removed in favor of submission

ISSUES CLOSED: #1469
benjamincharity added a commit that referenced this issue Oct 25, 2019
@benjamincharity
fix(LoginForm): remove deprecated submit emitter
5395a7b 
submit emitter removed in favor of submission

BREAKING CHANGE:
submit emitter removed in favor of submission

ISSUES CLOSED: #1469
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjamincharity benjamincharity

Labels
💥 BREAKING CHANGE 💥 This issue is a breaking change requiring a major version bump Focus: component Issues concerning a specific component Goal: Library Stabilization A task needed to get the library closer to it's final state Type: chore Something that needs to be done but is not a bug or addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v15 GetTerminus/terminus-ui
1 participant
@benjamincharity