Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmation: Button 'jumps' when positioned before or after #1406

Closed
shani-terminus opened this issue Mar 8, 2019 · 0 comments
Closed

Confirmation: Button 'jumps' when positioned before or after #1406

shani-terminus opened this issue Mar 8, 2019 · 0 comments
Assignees
Labels
Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) Type: bug An implemented item with undesired effects

Comments

@shani-terminus
Copy link
Contributor

shani-terminus commented Mar 8, 2019

When the overlay position is before or after, the button jumps when the overlay is displayed the first time. This is happening because .ts-confirmation has padding: spacing() but that class isn't on the page until the button is clicked for the first time.

Technically speaking, the same thing occurs when the overlay is above or below, but the increased padding does not affect the positioning of the button.

kapture 2019-03-08 at 10 22 19


Solution:

The component has padding: spacing() set for the class ts-confirmation but it should really be on class ts-confirmation-overlay__panel

@benjamincharity benjamincharity added Type: bug An implemented item with undesired effects Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) labels Mar 11, 2019
@shani-terminus shani-terminus self-assigned this Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) Type: bug An implemented item with undesired effects
Projects
None yet
Development

No branches or pull requests

2 participants