Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table: Missing test coverage for dev warning #1392

Closed
benjamincharity opened this issue Mar 5, 2019 · 0 comments
Closed

Table: Missing test coverage for dev warning #1392

benjamincharity opened this issue Mar 5, 2019 · 0 comments
Assignees
@shani-terminus
Labels
Focus: testing Tests or test helpers Target: latest Issues related to the latest version of the library (master) Type: chore Something that needs to be done but is not a bug or addition

Comments

@benjamincharity
Copy link
Contributor

We need to add a test ensuring the warning is logged when an invalid column alignment is used:

Screen Shot 2019-03-05 at 7.07.31 AM.png
@benjamincharity benjamincharity added Focus: testing Tests or test helpers Target: latest Issues related to the latest version of the library (master) Type: chore Something that needs to be done but is not a bug or addition labels Mar 5, 2019
@shani-terminus shani-terminus self-assigned this Mar 15, 2019
shani-terminus added a commit that referenced this issue Mar 15, 2019
@shani-terminus
chore(Table): warning message is tested
a3b77d6 
ISSUES CLOSED: #1392
@shani-terminus shani-terminus mentioned this issue Mar 15, 2019
Closed
benjamincharity added a commit that referenced this issue Mar 18, 2019
@benjamincharity
test(Table): added missing test for incorrect param
f2159c2 
ISSUES CLOSED: #1392
@benjamincharity benjamincharity mentioned this issue Mar 18, 2019
Merged
benjamincharity added a commit that referenced this issue Mar 18, 2019
@benjamincharity
test(Table): added missing test for incorrect param
6328a42 
ISSUES CLOSED: #1392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shani-terminus shani-terminus

Labels
Focus: testing Tests or test helpers Target: latest Issues related to the latest version of the library (master) Type: chore Something that needs to be done but is not a bug or addition
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benjamincharity @shani-terminus