Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select: Merged positioning bugs #1351

Closed
5 tasks done
benjamincharity opened this issue Feb 11, 2019 · 1 comment
Closed
5 tasks done

Select: Merged positioning bugs #1351

benjamincharity opened this issue Feb 11, 2019 · 1 comment
Assignees
Labels
Focus: component Issues concerning a specific component P2: Urgent Target: latest Issues related to the latest version of the library (master) Type: bug An implemented item with undesired effects

Comments

@benjamincharity
Copy link
Contributor

benjamincharity commented Feb 11, 2019

  • Fix horizontal panel position for checkbox and optgroup selects
  • Re-enable panel opening up
  • Fix issue where panel opens upwards too far away from select
  • Selected option should be vertically centered over select
  • Update any tests

Select: Needs more exact horizontal panel positioning

Currently the panel is opened slightly off-centered when dealing with optgroups or checkboxes:

Screen Shot 2018-12-14 at 12.42.51 PM.png

screen shot 2019-02-11 at 7 55 02 am

This is likely due to the padding changes for selects with checkboxes.

Select: Panel positioning off when opening up

This seems to be intermittent, but at times when opening up, the panel is much too high

screen_shot_2019-02-07_at_4.18.08_pm.png

Select: Selected option not fully centered vertically

When a select panel opens, the selected item should be vertically centered.

Screen Shot 2018-12-14 at 12.44.23 PM.png

@benjamincharity benjamincharity self-assigned this Feb 11, 2019
@benjamincharity benjamincharity added Focus: component Issues concerning a specific component P2: Urgent Status: Core Needs Today Target: latest Issues related to the latest version of the library (master) Type: bug An implemented item with undesired effects labels Feb 11, 2019
benjamincharity added a commit that referenced this issue Feb 13, 2019
Selected option is now always visible on open

ISSUES CLOSED: #1351
benjamincharity added a commit that referenced this issue Feb 13, 2019
Selected option is now always visible on open

ISSUES CLOSED: #1351
@benjamincharity
Copy link
Contributor Author

🎉 This issue has been resolved in version 11.1.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Focus: component Issues concerning a specific component P2: Urgent Target: latest Issues related to the latest version of the library (master) Type: bug An implemented item with undesired effects
Projects
None yet
Development

No branches or pull requests

1 participant