Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValidationMessages: Align phrasing for all messages #1190

Closed
2 tasks
benjamincharity opened this issue Jan 2, 2019 · 1 comment
Closed
2 tasks

ValidationMessages: Align phrasing for all messages #1190

benjamincharity opened this issue Jan 2, 2019 · 1 comment
Assignees
@shani-terminus
Labels
Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) Type: chore Something that needs to be done but is not a bug or addition

Comments

@benjamincharity
Copy link
Contributor

benjamincharity commented Jan 2, 2019 •
edited
Loading

  • Update messages
  • Verify tests are not dependent on specific strings

We have begun aligning all messages to match the format:

  • '${validatorValue.actual}' must be equal to '${validatorValue.compareValue}'
  • Must contain at least ${validatorValue.uppercase} uppercase letters,
  • etc

We should go through remaining messages to align:

ie:

minLength: `Minimum length ${validatorValue.requiredLength}.`,
@benjamincharity benjamincharity added Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) Type: chore Something that needs to be done but is not a bug or addition labels Jan 2, 2019
@shani-terminus shani-terminus self-assigned this Mar 8, 2019
shani-terminus added a commit that referenced this issue Mar 8, 2019
@shani-terminus
chore(ValidationMessages): phrasing is aligned
d531af0 
tests are more lenient on phrasing

ISSUES CLOSED: #1190
@shani-terminus
Copy link
Contributor

The tests are more lenient, depending on keywords, but not whole phrases. This is not the case for the date and image ratio validators, those tests weren't touched.

@shani-terminus shani-terminus mentioned this issue Mar 8, 2019
Merged
shani-terminus added a commit that referenced this issue Mar 15, 2019
@shani-terminus
chore(ValidationMessages): phrasing is aligned
90fd874 
tests are more lenient on phrasing

ISSUES CLOSED: #1190
benjamincharity pushed a commit that referenced this issue Mar 18, 2019
@shani-terminus @benjamincharity
chore(ValidationMessages): phrasing is aligned
a97ccd8 
tests are more lenient on phrasing

ISSUES CLOSED: #1190
benjamincharity pushed a commit that referenced this issue Mar 18, 2019
@shani-terminus @benjamincharity
chore(ValidationMessages): phrasing is aligned
225eb46 
tests are more lenient on phrasing

ISSUES CLOSED: #1190
benjamincharity pushed a commit that referenced this issue Mar 18, 2019
@shani-terminus @benjamincharity
chore(ValidationMessages): phrasing is aligned
633eaec 
tests are more lenient on phrasing

ISSUES CLOSED: #1190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shani-terminus shani-terminus

Labels
Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) Type: chore Something that needs to be done but is not a bug or addition
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benjamincharity @shani-terminus