-
Notifications
You must be signed in to change notification settings - Fork 43
feat: allow multiple simultaneous active calls #977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #977 +/- ##
========================================
+ Coverage 1.75% 2.69% +0.93%
========================================
Files 571 571
Lines 38295 38358 +63
========================================
+ Hits 673 1032 +359
+ Misses 37622 37326 -296 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments about backwards compatibility.
client_state.dart
is not exported from the library, but is accessible through StreamVideo.state
, so it's technically part of the public API.
Not sure if we can completely prevent breaking changes, but I would really prefer to start limiting them whenever possible. Especially in this case, where preventing the breaking changes also makes it easier for most developers, as having multiple active calls isn't the main usecase of the libary.
Co-authored-by: Rene Floor <rene.floor@getstream.io>
…am/stream-video-flutter into feat/allow-multiple-active-calls
resolves FLU-158
🎯 Goal
Right now, our Video SDK only allows one active call at a time. We keep track of the active call in a state, and when a new call connects, we always end the previous one. We want to allow multiple active calls to happen in the same time as some clients have this requirement. This PR makes it possible.
🛠 Implementation details
allowMultipleActiveCalls
has been added toStreamVideoOptions
.StreamBackgroundService
is also adjusted, showing multiple notifications