Skip to content

fix: listen to unread count stream #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2025
Merged

fix: listen to unread count stream #938

merged 3 commits into from
Apr 30, 2025

Conversation

renefloor
Copy link
Contributor

@renefloor renefloor commented Apr 15, 2025

🎯 Goal

fixes FLU-108
other part is fixed by updating the chat sdk

🛠 Implementation details

We didn't listen to unread changes, now we do. Somehow unread count is still always 0.

🎨 UI Changes

Screen.Recording.2025-04-17.at.10.03.07.mov

🧪 Testing

Join a call on 2 devices and chat with each other :)

☑️Contributor Checklist

General

  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#flutter-team) (required)
  • PR is linked to the GitHub issue it resolves

☑️Reviewer Checklist

  • Sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • All code we touched has new or updated Documentation

@renefloor renefloor force-pushed the fix/unread-chats-badge branch from a86e3e7 to 50c501c Compare April 17, 2025 08:00
@renefloor renefloor marked this pull request as ready for review April 17, 2025 08:01
@renefloor renefloor requested a review from a team as a code owner April 17, 2025 08:01
Copy link
Contributor

@Brazol Brazol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renefloor renefloor merged commit ae31f76 into main Apr 30, 2025
7 checks passed
@renefloor renefloor deleted the fix/unread-chats-badge branch April 30, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants