Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attachments picker popover crash #977

Closed
wants to merge 1 commit into from
Closed

Fix attachments picker popover crash #977

wants to merge 1 commit into from

Conversation

mvasilak
Copy link
Contributor

@mvasilak mvasilak commented Apr 9, 2021

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

Fixes a crash that occurs in iPad when the ChatMessageComposerVC attempts to present the attachment picker.

@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #977 (5aba9f4) into main (d8f43bb) will decrease coverage by 0.02%.
The diff coverage is 90.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #977      +/-   ##
==========================================
- Coverage   89.62%   89.59%   -0.03%     
==========================================
  Files         210      211       +1     
  Lines        8739     8768      +29     
==========================================
+ Hits         7832     7856      +24     
- Misses        907      912       +5     
Flag Coverage Δ
llc-tests 89.59% <90.38%> (-0.03%) ⬇️
llc-tests-ios12 85.88% <78.84%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Sources/StreamChat/Models/Channel.swift 73.91% <83.33%> (ø)
Sources/StreamChat/Utils/CoreDataLazy.swift 87.50% <87.50%> (ø)
Sources/StreamChat/Database/DTOs/MessageDTO.swift 95.44% <92.85%> (-0.24%) ⬇️
Sources/StreamChat/Database/DTOs/ChannelDTO.swift 98.95% <100.00%> (+<0.01%) ⬆️
Sources/StreamChat/Models/Message.swift 88.09% <100.00%> (ø)
Sources/StreamChat/Utils/Cached.swift 76.47% <0.00%> (-5.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc0c534...5aba9f4. Read the comment docs.

@b-onc
Copy link
Contributor

b-onc commented May 6, 2021

Closing this due to #1060 but thanks a lot, @mvasilak ! We'll add you to the CHANGELOG entry for this issue.

@b-onc b-onc closed this May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants