[CIS-363] Sample app improvements #549
Conversation
Codecov Report
@@ Coverage Diff @@
## main #549 +/- ##
=======================================
Coverage 88.59% 88.59%
=======================================
Files 155 155
Lines 5655 5655
=======================================
Hits 5010 5010
Misses 645 645 Continue to review full report at Codecov.
|
| ] | ||
|
|
||
| if let user = users.randomElement() { | ||
| if let user = Configuration.TestUser.defaults.shuffled().first(where: { $0.id != userId }) { |
There was a problem hiding this comment.
Nice trick 👍 I'd do filter { $0.id != userId}.randomElement() but yours is probably more efficient :)
| @available(iOS 14, *) | ||
| struct ChatView: View { | ||
| /// The `ChannelController` used to interact with this channel. Will be synchronized in `onAppear`. | ||
| @StateObject var channel: ChatChannelController.ObservableObject | ||
| /// The `text` written in the message composer. | ||
| @State var text: String = "" | ||
| /// Binding for message actions and channel actions ActionSheet. | ||
| @State var actionSheetTrigger: Bool = false | ||
| /// Message being edited. | ||
| @State var editingMessage: ChatMessage? | ||
| import Combine | ||
| import StreamChatClient | ||
| import SwiftUI |
There was a problem hiding this comment.
nit: I don't think we need to intend code wrapped inside #if endif
There was a problem hiding this comment.
hmm, seems like formatter indented it, not me. I agree with you, let me check if I can disable that
There was a problem hiding this comment.
Question: should we also build sample app in iOS12?
I'd say yes just because we have so many#ifchecks in there :)
Fixed in 5e88f6b
| /// Protocol conformance needed for ActionSheet presenting. | ||
| extension ChatUser: Identifiable {} |
There was a problem hiding this comment.
I already commented somewhere that this should live inside the SDK. Someone must have ignored it 🙃
|
We were hiding the token cell in override func tableView(_ tableView: UITableView, heightForRowAt indexPath: IndexPath) -> CGFloat {
switch tableView.cellForRow(at: indexPath) {
case jwtCell:
return heightForJwtCell()
default:
return super.tableView(tableView, heightForRowAt: indexPath)
}
}calling |
b-onc
force-pushed
the
cis-363-sample-app-improvements
branch
from
16df8a3 to
5e88f6b
Compare
Sources_v3/Models/User.swift
Outdated
| /// Protocol conformance needed for ActionSheet presenting. | ||
| extension ChatUser: Identifiable {} | ||
|
|
There was a problem hiding this comment.
- Think this should be in some iOS13 only user-related file like
UserController+SwiftUI.swift - It should be public
There was a problem hiding this comment.
Fixed in 04964ff
Doesn't need to be public since the original typealias is public
Also mainlined how we're using test data/users
We're switching to SPM from Carthage since Carthage pre-building frameworks uses different swift versions for different Xcodes. Also refactored github actions to not use Carthage anymore for v3
b-onc
force-pushed
the
cis-363-sample-app-improvements
branch
from
04964ff to
076e070
Compare
Question: should we also build sample app in iOS12?
Currently, Github Actions has Xcode11.7 as default. Default Xcode will be changed to Xcode 12.0 on October, 20, but we should still be fine.