-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file property to the ImageAttachmentPayload #3548
Merged
Merged
+98
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laevandus
added
🐞 Bug
An issue or PR related to a bug
🌐 SDK: StreamChat (LLC)
Tasks related to the StreamChat LLC SDK
labels
Jan 3, 2025
laevandus
commented
Jan 3, 2025
laevandus
force-pushed
the
feature/image-attachment-file-size
branch
from
January 3, 2025 09:19
532fb66
to
c82cee2
Compare
SDK Size
|
SDK Performance
|
SDK Size
|
nuno-vieira
reviewed
Jan 3, 2025
nuno-vieira
reviewed
Jan 3, 2025
nuno-vieira
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✅
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🐞 Bug
An issue or PR related to a bug
🌐 SDK: StreamChat (LLC)
Tasks related to the StreamChat LLC SDK
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves IOS-319
🎯 Goal
Fix an issue where
ImageAttachmentPayload
does not setfile_size
and/ormime_type
📝 Summary
ImageAttachmentPayload.file
and new init method requiring settingfile
init(title:imageRemoteURL:originalWidth:originalHeight:extraData:)
in favour ofinit(title:imageRemoteURL:file:originalWidth:originalHeight:extraData:)
ImageAttachmentPayload
to other attachment payloads which requirefile
to be set🛠 Implementation
Other attachment payloads require
AttachmentFile
type when creating a payload.ImageAttachmentPayload
is the only one which represents a file, but does not require it. This leads to all the image attachments sent from the iOS SDK to not setfile_size
and/ormime_type
.🧪 Manual Testing Notes
☑️ Contributor Checklist
docs-content
repo