Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIS-1105] Take a more defensive approach for user.role #1365

Merged
merged 5 commits into from
Aug 12, 2021

Conversation

tbarbugli
Copy link
Member

Replace force-unwrap with a custom case for user roles.

@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Aug 12, 2021

2 Errors
🚫 Please use more than one word.
2aa47ee
🚫 Please start subject with capital letter.
a50eab8

Generated by 🚫 Danger

b-onc
b-onc previously approved these changes Aug 12, 2021
Copy link
Contributor

@b-onc b-onc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG please

@tbarbugli tbarbugli changed the title take a more defensive approach for user.role [CIS-1105] Take a more defensive approach for user.role Aug 12, 2021
@tbarbugli tbarbugli requested review from b-onc and nuno-vieira August 12, 2021 09:14
Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to replicate the MemberRole's implementation: #1288

Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@tbarbugli tbarbugli merged commit 27620e1 into main Aug 12, 2021
@tbarbugli tbarbugli deleted the defensive-user-role branch August 12, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants