Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIS-1096] Fix an issue for ChatThreadVC opened from a deeplink #1354

Merged
merged 2 commits into from
Aug 10, 2021

Conversation

dmigach
Copy link
Contributor

@dmigach dmigach commented Aug 10, 2021

...when new replies are only added to the main chat, but not to the replies thread

The fix makes sure that we set thread message to the ComposerVC after synchronize executes. There is still an edge case for really fast users with really slow connection though 🙂
Before merging this we need to run it by Oscar

@dmigach dmigach requested review from b-onc and tbarbugli August 10, 2021 12:49
… are only added to the chat, but not to the replies thread
@dmigach dmigach force-pushed the CIS-1096-thread-message-issue branch from 7e4b0e0 to e73dfe6 Compare August 10, 2021 12:50
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2021

Codecov Report

Merging #1354 (c94f096) into main (e657a92) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1354      +/-   ##
==========================================
+ Coverage   90.75%   90.77%   +0.02%     
==========================================
  Files         224      224              
  Lines        9800     9800              
==========================================
+ Hits         8894     8896       +2     
+ Misses        906      904       -2     
Flag Coverage Δ
llc-tests 90.77% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ocketClient/Engine/URLSessionWebSocketEngine.swift 62.50% <0.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e657a92...c94f096. Read the comment docs.

@dmigach dmigach force-pushed the CIS-1096-thread-message-issue branch from e578760 to c94f096 Compare August 10, 2021 17:22
@tbarbugli tbarbugli merged commit 1be74e0 into main Aug 10, 2021
@tbarbugli tbarbugli deleted the CIS-1096-thread-message-issue branch August 10, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants