Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIS-1042] Fix deleted message's appearance on channel list #1318

Merged
merged 2 commits into from
Jul 26, 2021

Conversation

SagarSDagdu
Copy link
Contributor

What does this PR do

  • This PR fixes the appearance of a message in the channel list in the case where the channel's last message is a deleted one. Instead of showing the actual text of the message, we show the "Message Deleted" string.

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2021

Codecov Report

Merging #1318 (16bcc9f) into main (ef7eaa7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1318   +/-   ##
=======================================
  Coverage   91.27%   91.27%           
=======================================
  Files         226      226           
  Lines        9718     9718           
=======================================
  Hits         8870     8870           
  Misses        848      848           
Flag Coverage Δ
llc-tests 91.27% <ø> (ø)
llc-tests-ios12 91.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef7eaa7...16bcc9f. Read the comment docs.

Copy link
Contributor

@DominikBucher12 DominikBucher12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@SagarSDagdu SagarSDagdu merged commit 6acd58c into main Jul 26, 2021
@SagarSDagdu SagarSDagdu deleted the CIS-1042-last-message-deleted branch July 26, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants