Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gallery in Slack clone app #1300

Merged
merged 5 commits into from
Aug 9, 2021
Merged

Fix gallery in Slack clone app #1300

merged 5 commits into from
Aug 9, 2021

Conversation

evsaev
Copy link
Contributor

@evsaev evsaev commented Jul 21, 2021

This PR fixes broken gallery view in Slack app clone

@evsaev evsaev self-assigned this Jul 21, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2021

Codecov Report

Merging #1300 (9e12550) into main (58bb9f6) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1300      +/-   ##
==========================================
+ Coverage   91.17%   91.22%   +0.05%     
==========================================
  Files         222      222              
  Lines        9617     9617              
==========================================
+ Hits         8768     8773       +5     
+ Misses        849      844       -5     
Flag Coverage Δ
llc-tests 91.22% <ø> (+0.05%) ⬆️
llc-tests-ios12 91.22% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eamChat/APIClient/Endpoints/Payloads/RawJSON.swift 90.47% <0.00%> (+11.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58bb9f6...9e12550. Read the comment docs.

@tbarbugli tbarbugli merged commit 08b7477 into main Aug 9, 2021
@tbarbugli tbarbugli deleted the fix/slack-gallery branch August 9, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants