Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIS-996] Fix unread count badge hiding logic #1259

Merged
merged 2 commits into from
Jul 8, 2021

Conversation

skorepak
Copy link
Contributor

@skorepak skorepak commented Jul 8, 2021

This PR

  • fixes unread count badge logic allowing the badge to be shown with 0

Links

https://stream-io.atlassian.net/browse/CIS-996

@skorepak skorepak requested a review from VojtaStavik July 8, 2021 12:04
@Stream-SDK-Bot
Copy link
Collaborator

1 Message
📖 There seems to be app changes but CHANGELOG wasn't modified.
Please include an entry if the PR includes user-facing changes.
You can find it at CHANGELOG.md.

Generated by 🚫 Danger

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2021

Codecov Report

Merging #1259 (95ee7d4) into main (8dc565a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1259   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files         219      219           
  Lines        9400     9400           
=======================================
  Hits         8603     8603           
  Misses        797      797           
Flag Coverage Δ
llc-tests 91.36% <ø> (ø)
llc-tests-ios12 88.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dc565a...95ee7d4. Read the comment docs.

@skorepak skorepak force-pushed the CIS-996-Unread-badge-count branch from 6b15fb0 to 1d89ba9 Compare July 8, 2021 13:02
@skorepak skorepak merged commit 60bd4f5 into main Jul 8, 2021
@skorepak skorepak deleted the CIS-996-Unread-badge-count branch July 8, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants