[CIS-877] User typing events #1254
Conversation
skorepak
requested review from
b-onc,
VojtaStavik,
nuno-vieira,
evsaev and
DominikBucher12
Generated by 🚫 Danger |
Codecov Report
@@ Coverage Diff @@
## main #1254 +/- ##
==========================================
- Coverage 91.40% 91.38% -0.02%
==========================================
Files 219 219
Lines 9419 9421 +2
==========================================
Hits 8609 8609
- Misses 810 812 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
skorepak
force-pushed
the
CIS-877-User-typing-events
branch
from
79a217c to
855eeea
Compare
| public let currentlyTypingMembers: Set<_ChatChannelMember<ExtraData.User>> | ||
|
|
||
| /// A list of currently typing users. | ||
| public let currentlyTypingUsers: Set<_ChatUser<ExtraData.User>> |
There was a problem hiding this comment.
would be nice to have backing @CoreDataLazy field for this
There was a problem hiding this comment.
done 👍🏻 , please check
There was a problem hiding this comment.
Can you please add the currentlyTypingMembers variable into Deprecations.swift (with empty implementation) and mark it as renamed? It will help customers with the transition because they will be able to apply fixits.
| public let currentlyTypingMembers: Set<_ChatChannelMember<ExtraData.User>> | ||
|
|
||
| /// A list of currently typing users. | ||
| public let currentlyTypingUsers: Set<_ChatUser<ExtraData.User>> |
There was a problem hiding this comment.
Can you please add the currentlyTypingMembers variable into Deprecations.swift (with empty implementation) and mark it as renamed? It will help customers with the transition because they will be able to apply fixits.
CHANGELOG.md
Outdated
| @@ -5,6 +5,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). | |||
|
|
|||
| # Upcoming | |||
|
|
|||
| ### ⚠️ Breaking Changes from `4.0-beta.5` | |||
| - Changed ChannelDTO from `currentlyTypingMembers: Set<MemberDTO>` to `currentlyTypingUsers: Set<UserDTO>` to show all typing users (not only channel members; eg: watching users) [#1254](https://github.com/GetStream/stream-chat-swift/pull/1254) | |||
There was a problem hiding this comment.
DTOs are internal types, please refer to the public API that was changed
skorepak
force-pushed
the
CIS-877-User-typing-events
branch
from
a2f6c70 to
ffbd6d0
Compare
This PR
currentlyTypingMebmerswithcurrentlyTypingUsersChatChannelMembertoChatUserLinks
https://stream-io.atlassian.net/browse/CIS-877