[CIS-969] Date overlay jumps when loading more messages #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1235 +/- ##
==========================================
- Coverage 91.30% 91.28% -0.03%
==========================================
Files 218 218
Lines 9353 9353
==========================================
- Hits 8540 8538 -2
- Misses 813 815 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
evsaev
force-pushed
the
CIS-969-date-overlay-jumps-when-loading-more-messages
branch
from
c76b753 to
8a160ee
Compare
VojtaStavik
approved these changes
Jun 30, 2021
CHANGELOG.md
Outdated
| @@ -44,6 +44,7 @@ _June 23, 2021_ | |||
| ### 🔄 Changed | |||
| - `scrollToLatestMessageButton` is now visible every time the last message is not visible. Not only when there is unread message. [#1208](https://github.com/GetStream/stream-chat-swift/pull/1208) | |||
| - `mediaPickerVC` in `ComposerVC` updated to show both photos and videos [#1194](https://github.com/GetStream/stream-chat-swift/pull/1194) | |||
| - `ChatMessageListScrollOverlayView` moved outside the `ChatMessageListView`. Now it's managed by `ChatMessageListVC` [#1235](https://github.com/GetStream/stream-chat-swift/pull/1235) | |||
There was a problem hiding this comment.
Should we include it to the thread view, too?
There was a problem hiding this comment.
✅ done. Please have a look
evsaev
force-pushed
the
CIS-969-date-overlay-jumps-when-loading-more-messages
branch
from
8a160ee to
40ad59c
Compare
evsaev
force-pushed
the
CIS-969-date-overlay-jumps-when-loading-more-messages
branch
from
40ad59c to
0d163c5
Compare
evsaev
force-pushed
the
CIS-969-date-overlay-jumps-when-loading-more-messages
branch
from
0d163c5 to
5d023d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed the issue when date overlay jumps when loading more but moving an overlay outside the list view.
Tried the following first:
preserveSuperviewLayoutMargins = trueand keep pinning toself.layoutMarginssuperview.layoutMarginsdirectlycontentOffset.yand none of it works 🚫. It seems
layoutMarginsfollow the content size of table view when it changes and only after margins are updated to fit visible content area. Trying to follow thecontentOffset.ywould also involve following thecontentSize.heightwhich makes the logic of calculating the constraint too complicated.fixed-date-indicator.mp4