[CIS-907] Add Working with the Composer Guide #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuno-vieira
requested review from
b-onc,
VojtaStavik,
dmigach,
evsaev and
DominikBucher12
nuno-vieira
force-pushed
the
CIS-907-Working-with-the-composer-guide
branch
3 times, most recently
from
34d676e to
2e905a1
Compare
|
The guide should also show how to update the composer height, to show more lines (3 instead of 2), related message in slack |
tbarbugli
reviewed
Jun 28, 2021
nuno-vieira
force-pushed
the
CIS-907-Working-with-the-composer-guide
branch
from
2e905a1 to
60f42f4
Compare
Codecov Report
@@ Coverage Diff @@
## main #1195 +/- ##
=======================================
Coverage 91.40% 91.40%
=======================================
Files 219 219
Lines 9419 9419
=======================================
Hits 8609 8609
Misses 810 810
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
nuno-vieira
force-pushed
the
CIS-907-Working-with-the-composer-guide
branch
6 times, most recently
from
0dff854 to
08aedbd
Compare
tbarbugli
approved these changes
Jul 8, 2021
tbarbugli
approved these changes
Jul 8, 2021
nuno-vieira
force-pushed
the
CIS-907-Working-with-the-composer-guide
branch
from
962a16a to
0b54782
Compare
To follow the pattern of the rest of the view controllers
Disabling the suggestions should be on the recognizing of the commands, so it does not have to do the work for nothing
This will make sure there's enough padding on the right side of the composer
It includes an example on how to create a custom typing suggestion
nuno-vieira
force-pushed
the
CIS-907-Working-with-the-composer-guide
branch
from
b3673ac to
e4f6ef5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the pull request
How to Test
https://stream-composer-guide.loca.lt/chat/docs/sdk/ios/guides/working-with-the-composer (In case it is offline, please ask me on Slack to put it online)