Fix app auto-reconnect on background #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-onc
force-pushed
the
fix-reconnection
branch
4 times, most recently
from
e5eeeeb to
5aa1f5e
Compare
VojtaStavik
reviewed
Jun 9, 2021
Sources/StreamChat/ChatClient.swift
Outdated
| cancelBackgroundTaskIfNeeded() | ||
|
|
||
| guard config.shouldConnectAutomatically else { return } | ||
| guard connectionStatus != .connected && connectionStatus != .connected else { |
There was a problem hiding this comment.
nit: we should maybe add one more && connectionStatus != .connected to be 300% sure 
There was a problem hiding this comment.
let confidenceChecks = (1...10).random()
for _ in confidenceChecks {
guard connectionStatus != .connected else { return }
}
b-onc
force-pushed
the
fix-reconnection
branch
3 times, most recently
from
dbc11f8 to
45cc880
Compare
Generated by 🚫 Danger |
VojtaStavik
approved these changes
Jun 10, 2021
Comment on lines
+69
to
+70
| /// If set to `true`, the `ChatClient` will try to stay connected while app is backgrounded. | ||
| /// If set to `false`, websocket disconnects immediately when app is backgrounded. |
There was a problem hiding this comment.
nit: Would be fine to mention that the client starts starts a background task for this
Also moves the handling logic from WSClient to ChatClient. Basically, when we disconnected, we automatically set a timer for reconnection, and reconnected while in background.
Codecov Report
@@ Coverage Diff @@
## main #1170 +/- ##
==========================================
- Coverage 91.31% 91.24% -0.08%
==========================================
Files 217 217
Lines 9248 9261 +13
==========================================
+ Hits 8445 8450 +5
- Misses 803 811 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also moves the handling logic from WSClient to ChatClient.
Basically, when we disconnected, we automatically set a timer for reconnection, and reconnected while in background.