Send typingStop event when message editing finished
#1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a temporary fix until the feature is implemented on the LLC level in CIS-883
Codecov Report
@@ Coverage Diff @@
## main #1152 +/- ##
==========================================
- Coverage 91.36% 91.26% -0.10%
==========================================
Files 216 217 +1
Lines 9215 9247 +32
==========================================
+ Hits 8419 8439 +20
- Misses 796 808 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
evsaev
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing this on the LLC level requires some refactoring around
TypingEventSender(CIS-883). This is just a temporary fix until the feature is implemented on the LLC level.(spotted on the video by @evsaev here #1148 (comment) :) )