-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIS-997] Fix over fetching previous messages #1110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this approach is good 👍
bed70e4
to
ccf5468
Compare
Codecov Report
@@ Coverage Diff @@
## main #1110 +/- ##
==========================================
- Coverage 91.38% 91.36% -0.02%
==========================================
Files 219 219
Lines 9421 9432 +11
==========================================
+ Hits 8609 8618 +9
- Misses 812 814 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ccf5468
to
d1c80fb
Compare
57f44c0
to
401e2b1
Compare
401e2b1
to
5b4d624
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Description of the pull request
When getting the previous messages, we would make unnecessary requests. Now we only load the previous messages if there's more to fetch.
The only thing left to do is add test cases. I will do it once the implementation approach is approved.