Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SPM warning #1031

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Fix SPM warning #1031

merged 1 commit into from
Apr 29, 2021

Conversation

Overcot
Copy link
Contributor

@Overcot Overcot commented Apr 28, 2021

Fixes spm warning that showed that we need to explicilty mark .stencil file as resource or exclude it from target

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

Fixes spm warning that showed that we need to explicilty mark .stencil file as resource or exclude it from target
@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #1031 (88124a0) into main (2052e67) will increase coverage by 0.03%.
The diff coverage is 96.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1031      +/-   ##
==========================================
+ Coverage   89.95%   89.99%   +0.03%     
==========================================
  Files         213      214       +1     
  Lines        8962     9006      +44     
==========================================
+ Hits         8062     8105      +43     
- Misses        900      901       +1     
Flag Coverage Δ
llc-tests 89.82% <96.61%> (+0.03%) ⬆️
llc-tests-ios12 86.63% <96.61%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../ChannelListController/ChannelListController.swift 93.18% <80.00%> (-1.69%) ⬇️
Sources/StreamChat/Controllers/Controller.swift 100.00% <100.00%> (ø)
...treamChat/Controllers/EntityDatabaseObserver.swift 100.00% <100.00%> (ø)
.../StreamChat/Controllers/ListDatabaseObserver.swift 93.45% <100.00%> (+0.59%) ⬆️
...ources/StreamChat/Database/DatabaseContainer.swift 97.03% <100.00%> (+0.13%) ⬆️
...at/Workers/Background/NewChannelQueryUpdater.swift 88.88% <100.00%> (+0.17%) ⬆️
...mChatTestTools/NSManagedObject+ContextChange.swift 100.00% <100.00%> (ø)
...ources/StreamChat/Controllers/DataController.swift 83.33% <0.00%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0335caf...88124a0. Read the comment docs.

@VojtaStavik VojtaStavik self-requested a review April 29, 2021 08:23
Copy link
Contributor

@VojtaStavik VojtaStavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time for this @Overcot 🙏

@VojtaStavik VojtaStavik merged commit a9f3324 into GetStream:main Apr 29, 2021
@VojtaStavik VojtaStavik changed the title Fix Spm warning Fix SPM warning Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants