-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CoreData concurrency #1026
Fix CoreData concurrency #1026
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1026 +/- ##
==========================================
+ Coverage 89.97% 89.99% +0.02%
==========================================
Files 213 214 +1
Lines 8986 9006 +20
==========================================
+ Hits 8085 8105 +20
Misses 901 901
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
f118df2
to
ee0b434
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✅ Thanks, didn't realise this flag wasn't ON already, it is very useful 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍 Just some minor changes and ergonomy tweaks.
Sources/StreamChat/Controllers/MessageController/MessageController_Tests.swift
Outdated
Show resolved
Hide resolved
7fc5816
to
1f0baa9
Compare
1f0baa9
to
6669f34
Compare
This PR fixes CoreData concurrency issues found by enabling
-com.apple.CoreData.ConcurrencyDebug
launch argument for demo app and forStreamChat
test plans.Closes #954