Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent firing load more when user is offline #614

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

mahboubii
Copy link
Contributor

not the most brilliant approach, but our WS is a little bit behind detecting network is down or not
well supported: https://developer.mozilla.org/en-US/docs/Web/API/NavigatorOnLine/onLine

@mahboubii mahboubii added the bug Something isn't working label Nov 19, 2020
@github-actions
Copy link

Size Change: +77 B (0%)

Total Size: 1.26 MB

Filename Size Change
./dist/browser.full-bundle.js 644 kB +15 B (0%)
./dist/browser.full-bundle.min.js 373 kB +16 B (0%)
./dist/index.es.js 105 kB +24 B (0%)
./dist/index.js 107 kB +22 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/css/index.css 23 kB 0 B
./dist/css/index.js 21 B 0 B
./dist/i18n/en.json 824 B 0 B
./dist/i18n/fr.json 1.25 kB 0 B
./dist/i18n/hi.json 1.43 kB 0 B
./dist/i18n/it.json 1.19 kB 0 B
./dist/i18n/nl.json 1.17 kB 0 B
./dist/i18n/ru.json 1.47 kB 0 B
./dist/i18n/tr.json 1.19 kB 0 B

compressed-size-action

Copy link

@ath92 ath92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I'm slightly weirded out by that camelCase for onLine)

@mahboubii mahboubii merged commit 63c4912 into master Nov 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/load-more-offline branch November 19, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants