Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Thread renders null if replies is disabled #580

Merged
merged 3 commits into from
Oct 19, 2020

Conversation

mahboubii
Copy link
Contributor

pending on #579 for tests to pass

@mahboubii mahboubii added the enhancement New feature or request label Oct 15, 2020
@github-actions
Copy link

github-actions bot commented Oct 15, 2020

Size Change: +211 B (0%)

Total Size: 1.25 MB

Filename Size Change
./dist/browser.full-bundle.js 639 kB +81 B (0%)
./dist/browser.full-bundle.min.js 371 kB +37 B (0%)
./dist/index.es.js 104 kB +47 B (0%)
./dist/index.js 106 kB +46 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/css/index.css 23 kB 0 B
./dist/css/index.js 21 B 0 B
./dist/i18n/en.json 790 B 0 B
./dist/i18n/fr.json 1.21 kB 0 B
./dist/i18n/hi.json 1.37 kB 0 B
./dist/i18n/it.json 1.14 kB 0 B
./dist/i18n/nl.json 1.12 kB 0 B
./dist/i18n/ru.json 1.4 kB 0 B
./dist/i18n/tr.json 1.14 kB 0 B

compressed-size-action

@jaapbakker88
Copy link
Contributor

@mahboubii can we also remove the reply button from the UI components?

@mahboubii
Copy link
Contributor Author

@mahboubii can we also remove the reply button from the UI components?

ofc, already on the todo list.

@mahboubii mahboubii merged commit 531c29c into master Oct 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/thread-channel-config branch October 19, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants