[CRS-276] Sanitize URL image sources in Image component #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some outdated browsers could potentially still allow javascript execution from img elements, which could lead to XSS. Although such browsers would fall outside the scope of our supported browsers, fixing the vulnerability is a simple, so we're opting for doing it here. It is important to note that the javascript check will be obsolete in the next major react version, where it will no longer render uris with javascript as a protocol.
vini-btc
force-pushed
the
fix/CRS-276-improve-attachment-sanitization
branch
from
00042a2 to
df5a8aa
Compare
vini-btc
changed the title
|
Size Change: +40 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
jaapbakker88
approved these changes
Sep 25, 2020
delete-merged-branch
bot
deleted the
fix/CRS-276-improve-attachment-sanitization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some outdated browsers could still allow javascript execution from img
elements, which could lead to XSS. Although such browsers would fall
outside the scope of our supported browsers, fixing the vulnerability is
a simple, so we're opting for doing it here.
It is important to note that the javascript check will be obsolete in
the next major react version, where it will no longer render uris with
javascript as a protocol.