fix: use the client pagination indicators for ChannelStateContext's hasMore and hasMoreNewer flags #2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asMore and hasMoreNewer flags
oliverlaz
approved these changes
Aug 22, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-v11 #2478 +/- ##
============================================
Coverage 85.48% 85.48%
============================================
Files 393 395 +2
Lines 9122 9131 +9
Branches 2356 2358 +2
============================================
+ Hits 7798 7806 +8
- Misses 1122 1123 +1
Partials 202 202 ☔ View full report in Codecov by Sentry. |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
## [11.23.7](v11.23.6...v11.23.7) (2024-08-22) ### Bug Fixes * use the client pagination indicators for ChannelStateContext's hasMore and hasMoreNewer flags ([#2478](#2478)) ([eb13bd5](eb13bd5))
|
🎉 This PR is included in version 11.23.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
## [12.0.0-rc.9](v12.0.0-rc.8...v12.0.0-rc.9) (2024-08-22) ### Bug Fixes * use the client pagination indicators for ChannelStateContext's hasMore and hasMoreNewer flags ([#2478](#2478)) ([eb13bd5](eb13bd5))
|
🎉 This PR is included in version 12.0.0-rc.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Use the pagination flags from the the client, which actually performs the queries and thus share the information btw React components that are siblings (
ChannelListqueries channels andChannelwill know, what channels have less than the 1st page size message count).depends on GetStream/stream-chat-js#1332