Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation fix and additionalTextareaProps prop support #184

Merged
merged 3 commits into from
Mar 26, 2020
Merged

Translation fix and additionalTextareaProps prop support #184

merged 3 commits into from
Mar 26, 2020

Conversation

vishalnarkhede
Copy link
Contributor

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

@vishalnarkhede vishalnarkhede self-assigned this Mar 26, 2020
vishalnarkhede
vishalnarkhede commented Mar 26, 2020
View reviewed changes
src/components/Message.js
@@ -499,3 +500,7 @@ export class Message extends Component {
);
}
}

Message = withTranslationContext(Message);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes #181

@jaapbakker88
Copy link
Contributor

Did you add the additionalTextareaProps to the EditMessageForm as well?

@vishalnarkhede
Copy link
Contributor Author

Did you add the additionalTextareaProps to the EditMessageForm as well?

Done!!

@vishalnarkhede vishalnarkhede merged commit 45944ce into master Mar 26, 2020
@delete-merged-branch delete-merged-branch bot deleted the vishal/bug-fixes branch March 26, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaapbakker88 jaapbakker88 jaapbakker88 approved these changes

Assignees

@vishalnarkhede vishalnarkhede

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vishalnarkhede @jaapbakker88