perf: faster addMessagesSorted #470
Conversation
mahboubii
requested review from
tbarbugli,
nhannah,
vishalnarkhede and
virdesai
|
Size Change: +254 B (0%) Total Size: 197 kB
|
| let middle = 0; | ||
| let right = messages.length - 1; | ||
| while (left <= right) { | ||
| middle = Math.floor((right + left) / 2); |
There was a problem hiding this comment.
In most cases wouldn't a bottom up approach be faster than a binary search given the likelihood of a message being further up is less?
There was a problem hiding this comment.
L462 takes care of that. cases like pagination could add some 100 more messages to the other end of the array which will be O(n), right now this part is O(log(n)) which is quite fast already
…chat-js into perf-addMessagesSorted
| @@ -1658,7 +1658,7 @@ export class Channel< | |||
| if (!this.state.messages) { | |||
| this.state.messages = Immutable([]); | |||
| } | |||
| this.state.addMessagesSorted(messages, true); | |||
| this.state.addMessagesSorted(messages, false, true); | |||
There was a problem hiding this comment.
Having options an object with keys would help for readability.
There was a problem hiding this comment.
3 params are fine, in case it grows we can change it to object
There was a problem hiding this comment.
I agree in general but when they are booleans, it's trickier.
fixes #465