feat: add message delivery receipts #1617
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinCupela
requested review from
vishalnarkhede,
santhoshvai,
khushal87,
szuperaz,
oliverlaz and
arnautov-anton
as code owners
2 tasks
|
Size Change: +15.3 kB (+3.35%) Total Size: 471 kB
|
MartinCupela
commented
Sep 11, 2025
MartinCupela
commented
Sep 11, 2025
| last_read_message_id: event.last_read_message_id, | ||
| user: event.user, | ||
| unread_messages: 0, | ||
| last_delivered_at: event.last_delivered_at |
There was a problem hiding this comment.
Probably not necessary to update delivery data here if we have read data
There was a problem hiding this comment.
will keep the data in sync with the back-end
rafaelmf3
reviewed
Sep 11, 2025
| async markChannelsDelivered(data?: MarkDeliveredOptions) { | ||
| const deliveryReceiptsEnabled = | ||
| this.user?.privacy_settings?.delivery_receipts?.enabled; | ||
| if (!deliveryReceiptsEnabled) return; |
There was a problem hiding this comment.
we could return some feedback to know that the privacy_setting is missing
There was a problem hiding this comment.
I don't plan it in this PR.
rafaelmf3
reviewed
Sep 12, 2025
…if does not exist in the event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Provide:
service for buffering of delivery confirmation payload (
client.deliveryReportCoordinatoris handling the buffering and throttling of the requests). See Buffering service section in the spec.WS event processing for read state updates (
message.new,message.read,notification.mark_unread,notification.channel_delivered- name may change)Spec
See description of CHA-991
Out of scope
The buffering service is prepared to handle delivery confirmation for threads too, but it is disabled for the moment.