fix: thread manager bugs #1372
Open
fix: thread manager bugs #1372
+91
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isekovanic
requested review from
vishalnarkhede,
santhoshvai,
khushal87,
szuperaz,
oliverlaz,
arnautov-anton,
MartinCupela and
myandrienko
as code owners
isekovanic
changed the title
|
Size Change: +925 B (+0.22%) Total Size: 428 kB
|
6 tasks
src/thread_manager.ts
Outdated
| @@ -117,6 +118,19 @@ export class ThreadManager<SCG extends ExtendableGenerics = DefaultGenerics> { | |||
| return () => unsubscribeFunctions.forEach((unsubscribe) => unsubscribe()); | |||
| }; | |||
|
|
|||
| private subscribeChannelDeleted = () => { | |||
| const unsubscribeFunctions = ['notification.channel_deleted', 'channel.deleted'].map((e) => { | |||
There was a problem hiding this comment.
Suggested change
| const unsubscribeFunctions = ['notification.channel_deleted', 'channel.deleted'].map((e) => { | |
| const unsubscribeFunctions = ['notification.channel_deleted'].map((e) => { |
One should suffice, notification-type events are always delivered - with less information - but in this case it's fine. With two in the array we're going to run the handler twice.
There was a problem hiding this comment.
Hey @arnautov-anton, notification events are not delivered for watched channels AFAIK. So we need to keep both.
myandrienko
approved these changes
Oct 7, 2024
MartinCupela
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLA
Description of the changes, What, Why and How?
This PR fixes 2 leftover issues in Threads v2:
ThreadManagerstate being stale after logging out in an appThreadManagerstateChangelog